Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support faker modifiers on Fabricator #8671

Merged
merged 3 commits into from
Mar 30, 2024
Merged

feat: Support faker modifiers on Fabricator #8671

merged 3 commits into from
Mar 30, 2024

Conversation

paulbalandan
Copy link
Member

Description
Closes #6812

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from 95932e1 to cc8c99e Compare March 28, 2024 14:16
michalsn
michalsn approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature.

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Mar 28, 2024
@kenjis
Copy link
Member

kenjis commented Mar 28, 2024

@paulbalandan Add a short description in
https://github.com/codeigniter4/CodeIgniter4/blob/4.5/user_guide_src/source/changelogs/v4.5.0.rst#testing

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from cc8c99e to 4610481 Compare March 29, 2024 13:28
@kenjis
Copy link
Member

kenjis commented Mar 30, 2024

Can you rebase to check GA checks?

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from 4610481 to 31afcfa Compare March 30, 2024 09:17
kenjis
kenjis approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 3574196 into codeigniter4:4.5 Mar 30, 2024
41 checks passed
@paulbalandan paulbalandan deleted the fabricator-modifiers branch March 31, 2024 09:57
@kenjis kenjis mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @michalsn