Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add charset and DBCollat for database.tests in env #8662

Merged
merged 1 commit into from
Mar 28, 2024
Merged

config: add charset and DBCollat for database.tests in env #8662

merged 1 commit into from
Mar 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 26, 2024 •
edited
Loading

Needs #8665

Description
By default, Config\Database::$tests is for SQLite3, and these values are different.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis marked this pull request as draft March 27, 2024 00:53
@kenjis kenjis added 4.5 database Issues or pull requests that affect the database layer labels Mar 27, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 28, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis
config: add charset and DBCollat for database.tests
9e10860 
By default, tests is for SQLite3, and these values are different.
@kenjis kenjis removed the stale Pull requests with conflicts label Mar 28, 2024
@kenjis kenjis marked this pull request as ready for review March 28, 2024 02:21
@kenjis
Copy link
Member Author

kenjis commented Mar 28, 2024

Rebased and ready for review.

datamweb
datamweb approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be interesting to know that Laravel 11 has set the default database connection to SQLite.

@kenjis kenjis merged commit e131c46 into codeigniter4:4.5 Mar 28, 2024
2 checks passed
@kenjis kenjis deleted the update-env branch March 28, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
4.5 database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb