Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable rector cache #8655

Merged
merged 9 commits into from
Mar 23, 2024
Merged

chore: Enable rector cache #8655

merged 9 commits into from
Mar 23, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 23, 2024 •
edited
Loading

Description

Let's try enable rector cache based on https://getrector.com/documentation/cache-in-ci

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

It seems working ok with merge multiple paths to single:

Before Time: 2m 43s

ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/8403997993/job/23015107946#step:11:1

After Time: 2s

ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/8404013987/job/23015144926?pr=8655#step:11:1

Ready to merge 👍

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Mar 23, 2024
kenjis
kenjis approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsonasik samsonasik merged commit f82dc32 into codeigniter4:develop Mar 23, 2024
9 checks passed
@samsonasik samsonasik deleted the rector-cache branch March 23, 2024 22:15
@kenjis
Copy link
Member

kenjis commented Mar 23, 2024

@samsonasik Can you update .github and devkit repositories?

@samsonasik samsonasik mentioned this pull request Mar 24, 2024
Merged
5 tasks
@samsonasik
Copy link
Member Author

@kenjis yes, I created PR:

for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @kenjis