Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary if check #8648

Merged
merged 2 commits into from
Mar 22, 2024
Merged

chore: remove unnecessary if check #8648

merged 2 commits into from
Mar 22, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Mar 21, 2024 •
edited by kenjis
Loading

Description

Remove unnecessary if check, applied by running latest rector/rector:dev-main

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@kenjis kenjis merged commit ae0e455 into codeigniter4:develop Mar 22, 2024
62 checks passed
@kenjis
Copy link
Member

kenjis commented Mar 22, 2024

@samsonasik Thank you!

@samsonasik samsonasik deleted the chore-remove-unnecessary-if-check branch March 22, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samsonasik @kenjis @datamweb @paulbalandan @ddevsr