Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add PHPStan checking to tests/ #8646

Merged
merged 2 commits into from
Mar 25, 2024
Merged

chore: add PHPStan checking to tests/ #8646

merged 2 commits into from
Mar 25, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 21, 2024

Description

  • add tests/

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis merged commit 114f3ce into codeigniter4:develop Mar 25, 2024
16 checks passed
@kenjis kenjis deleted the add-phpstan-check-tests branch March 25, 2024 23:21
@kenjis
Copy link
Member Author

kenjis commented Mar 25, 2024

@michalsn Thank you for reviews!

@kenjis kenjis mentioned this pull request Mar 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn