refactor: improve Validation Placeholder error message #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevsr
reviewed
Mar 20, 2024
| 'No validation rules for the placeholder: ' . $field | ||
| 'No validation rules for the placeholder: "' . $field | ||
| . '". You must set the validation rules for the field.' | ||
| . ' See <https://codeigniter4.github.io/userguide/libraries/validation.html#validation-placeholders>.' |
There was a problem hiding this comment.
Suggested change
| . ' See <https://codeigniter4.github.io/userguide/libraries/validation.html#validation-placeholders>.' | |
| . ' See <https://codeigniter.com/user_guide/libraries/validation.html#validation-placeholders>.' |
Consistent link
There was a problem hiding this comment.
I would like to use it, but see https://codeigniter.com/user_guide/changelogs/index.html
Now the official user guide is not updated.
See https://github.com/codeigniter4/userguide/actions/runs/8027707768/job/21932010657
kenjis
changed the title
michalsn
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8638
Checklist: