-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: esc() for 'raw' context #8633
Conversation
Please sign all commits. |
Sorry, I saw the requirement after PRing. It should be OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for data array? recursive and non-recursive
The following php-cs-fixer error is not related to this PR.
I sent a bug report: PHP-CS-Fixer/PHP-CS-Fixer#7896 |
Can you point me to an existing test for a function that I can use as an example? I'm not familiar with the CI project structure. |
See CodeIgniter4/tests/system/CommonFunctionsTest.php Lines 231 to 248 in fd6d674
|
I added two tests. I don't have much experience with unit tests so please tell me if it seems right. |
@Cleric-K Please fix the coding style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Cleric-K Thank you! |
Description
Fixes #8624
Checklist: