-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Debug] Backtrace does not display contents of file in PHP +8.3.0 #8616
Conversation
Thank you for sending PR! Can you explain what's the issue, and add test code to prove your fix? |
I think this is fixing the highlight_string output which I believe has been fixed already in 4.5 branch. |
In PHP versions 8.3.0 and above due to update of highlight_string function |
I think it was fixed in #8401. @Nightprince Can you show the steps to reproduce the issue? |
@Nightprince Can you post a screenshot before and after this PR? |
Before: After: |
It seems you are using very old CI4. Could you update to v4.4.6? |
@Nightprince As mentioned, your CI version is outdated. The output in the CI4.4.6 and PHP 8.3.0 is as follows: It is recommended to upgrade to the new version. Before anything else don't forget to make a backup then upgrade to the latest version step by step via: @kenjis I suggest moving the information shown in footer to the top, it can be helpful in reporting users. |
problem has been fixed in latest version, but this pull request can be useful for those who use older versions. |
We recommend to use the latest version. But if you really want to fix the deprecated method, modify it exactly the same way as the following change: |
Not important for me |
https://www.php.net/manual/en/function.highlight-string.php
Checklist: