Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add spark optimize command #8610

Merged
merged 5 commits into from
Mar 28, 2024
Merged

feat: add spark optimize command #8610

merged 5 commits into from
Mar 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 7, 2024 •
edited
Loading

Needs #8605

Description

  • add spark optimize command to:
    • enable caching features
    • clear cache
    • remove Composer dev packages

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Mar 7, 2024
@kenjis kenjis marked this pull request as draft March 7, 2024 08:45
@kenjis kenjis force-pushed the feat-add-spark-optimize branch from cf6360f to f5b0345 Compare March 7, 2024 10:36
lonnieezell
lonnieezell approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great foundation we can add more to over time as we implement or discover it.

@kenjis kenjis force-pushed the feat-add-spark-optimize branch from b4e48e6 to 51ceb27 Compare March 10, 2024 10:00
@kenjis kenjis mentioned this pull request Mar 11, 2024
Merged
5 tasks
@github-actions github-actions bot added the stale Pull requests with conflicts label Mar 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the feat-add-spark-optimize branch from 51ceb27 to 3dd0f82 Compare March 18, 2024 02:02
@kenjis kenjis removed the stale Pull requests with conflicts label Mar 18, 2024
@kenjis kenjis mentioned this pull request Mar 26, 2024
Merged
5 tasks
@kenjis kenjis force-pushed the feat-add-spark-optimize branch from 3dd0f82 to 46e3348 Compare March 27, 2024 23:51
@kenjis kenjis marked this pull request as ready for review March 27, 2024 23:53
@kenjis kenjis merged commit 301ffb8 into codeigniter4:4.5 Mar 28, 2024
41 checks passed
@kenjis kenjis deleted the feat-add-spark-optimize branch March 28, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @lonnieezell @michalsn @paulbalandan