Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: preload notes #8597

Merged
merged 10 commits into from
Mar 10, 2024
Merged

docs: preload notes #8597

merged 10 commits into from
Mar 10, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Mar 2, 2024

Description
Fixed #8596

For note using preload.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Mar 2, 2024
@ddevsr ddevsr mentioned this pull request Mar 2, 2024
Closed
@ddevsr ddevsr requested a review from kenjis March 2, 2024 02:48
@ddevsr ddevsr changed the base branch from develop to 4.5 March 2, 2024 03:56
@ddevsr ddevsr added the 4.5 label Mar 2, 2024
@ddevsr ddevsr requested a review from kenjis March 2, 2024 03:58
kenjis
kenjis reviewed Mar 2, 2024
View reviewed changes
preload.php Outdated Show resolved Hide resolved
@ddevsr ddevsr requested review from kenjis and paulbalandan March 7, 2024 10:00
paulbalandan
paulbalandan reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments below

user_guide_src/source/installation/deployment.rst Outdated

Open ``php.ini`` or ``xx-opcache.ini`` if you have split INI configuration in PHP, and recommend to set ``opcache.preload=/path/to/preload.php`` and ``opcache.preload_user=myuser``.

.. note:: ``myuser`` is user running in your web server. If you want find location split INI configuration, just run ``php --ini`` or open file ``phpinfo()`` and search *Additional .ini files parsed*.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to tell how to use phpinfo(). Just the terminal way is enough.

Suggested change
.. note:: ``myuser`` is user running in your web server. If you want find location split INI configuration, just run ``php --ini`` or open file ``phpinfo()`` and search *Additional .ini files parsed*.
.. note:: ``myuser`` is user running in your web server. If you want to find the location of the split INI configuration, just run ``php --ini`` in your terminal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The PHP ini files for web and CLI may be different.

user_guide_src/source/installation/deployment.rst Outdated Show resolved Hide resolved
@kenjis kenjis merged commit c38d7de into codeigniter4:4.5 Mar 10, 2024
8 checks passed
@kenjis
Copy link
Member

kenjis commented Mar 10, 2024

@ddevsr Thank you!

@ddevsr ddevsr deleted the preload branch March 11, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
4.5 documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Preload Cannot declare class Config\Paths, because the name is already in use
3 participants
@ddevsr @kenjis @paulbalandan