Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TimeTest #8593

Merged
merged 2 commits into from
Mar 5, 2024
Merged

test: fix TimeTest #8593

merged 2 commits into from
Mar 5, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 29, 2024

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
test: fix tests that fails on Feb 29
549db02
@kenjis
test: remove unnecessary timezone America/Chicago
a14ea36 
It is wrong to change the timezone only to setTestNow().
Remnants of the old code? Now UTC is the default timezone.
@kenjis kenjis added the testing Pull requests that changes tests only label Feb 29, 2024
@kenjis kenjis merged commit a99787c into codeigniter4:develop Mar 5, 2024
59 checks passed
@kenjis kenjis deleted the test-fix-TimeTest branch March 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan