Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 4.4.6 release #8574

Merged
merged 3 commits into from
Feb 24, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: fix by php-cs-fixer v3.50.0
kenjis committed Feb 24, 2024
commit bf39b5dce73faa14e59589f02733fbae5e372886
2 changes: 1 addition & 1 deletion system/I18n/TimeTrait.php
Original file line number Diff line number Diff line change
@@ -1153,7 +1153,7 @@ public function __toString(): string
*
* @param string $name
*
* @return array|bool|DateTimeInterface|DateTimeZone|int|intlCalendar|self|string|null
* @return array|bool|DateTimeInterface|DateTimeZone|int|IntlCalendar|self|string|null
*/
public function __get($name)
{
2 changes: 1 addition & 1 deletion system/Images/Handlers/ImageMagickHandler.php
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ public function _resize(bool $maintainRatio = false)
/**
* Crops the image.
*
* @return bool|\CodeIgniter\Images\Handlers\ImageMagickHandler
* @return bool|ImageMagickHandler
*
* @throws Exception
*/

Unchanged files with check annotations Beta

$this->assertSame(exif_imagetype($this->root . 'ci-logo.png'), IMAGETYPE_PNG);
}
public function testImageReorientLandscape(): void

Check warning on line 425 in tests/system/Images/ImageMagickHandlerTest.php

GitHub Actions / Others (8.1) / Sanity Tests

Took 0.55s from 0.50s limit to run CodeIgniter\\Images\\ImageMagickHandlerTest::testImageReorientLandscape
{
for ($i = 0; $i <= 8; $i++) {
$source = $this->origin . 'EXIFsamples/landscape_' . $i . '.jpg';
}
}
public function testImageReorientPortrait(): void

Check warning on line 444 in tests/system/Images/ImageMagickHandlerTest.php

GitHub Actions / Others (8.1) / Sanity Tests

Took 0.57s from 0.50s limit to run CodeIgniter\\Images\\ImageMagickHandlerTest::testImageReorientPortrait
{
for ($i = 0; $i <= 8; $i++) {
$source = $this->origin . 'EXIFsamples/portrait_' . $i . '.jpg';
$this->forge->createTable('forge_test_table');
}
public function testRenameTable(): void

Check warning on line 387 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, SQLSRV, 8.0) / tests

Took 0.51s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testRenameTable
{
$this->forge->dropTable('forge_test_table_dummy', true);
$this->forge->dropTable('', true);
}
public function testForeignKey(): void

Check warning on line 443 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 3.17s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
$this->forge->createTable('forge_test_invoices', true, $attributes);
}
public function testDropForeignKey(): void

Check warning on line 733 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, SQLSRV, 8.0) / tests

Took 0.52s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
$this->forge->dropTable('forge_test_1', true);
}
public function testSetKeyNames(): void

Check warning on line 1185 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.35s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testSetKeyNames
{
$this->forge->dropTable('forge_test_1', true);
$this->forge->dropTable('forge_test_two', true);
}
public function testModifyColumnRename(): void

Check warning on line 1281 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, SQLSRV, 8.0) / tests

Took 0.51s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testModifyColumnRename
{
$this->forge->dropTable('forge_test_three', true);
$this->forge->dropTable('forge_test_four', true);
}
public function testDropKey(): void

Check warning on line 1533 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.15s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropKey
{
$this->forge->dropTable('key_test_users', true);
$keyName = 'key_test_users_id';
$this->forge->dropTable('forge_test_users', true);
}
public function testProcessIndexes(): void

Check warning on line 1620 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.75s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes

Check warning on line 1620 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / DatabaseLive (8.1, SQLSRV, 8.0) / tests

Took 0.52s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes
{
// make sure tables don't exist
$this->forge->dropTable('actions', true);
$this->assertSame($expected, $result);
}
public function testMigrateWithWithTwoNamespaces(): void

Check warning on line 97 in tests/system/Commands/Database/MigrateStatusTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.72s from 0.50s limit to run CodeIgniter\\Commands\\Database\\MigrateStatusTest::testMigrateWithWithTwoNamespaces
{
command('migrate -n App');
command('migrate -n Tests\\\\Support');
$this->assertSame('MySQLi', $this->getPrivateProperty($db1, 'DBDriver'));
}
public function testConnectWithFailover(): void

Check warning on line 95 in tests/system/Database/Live/ConnectTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.35s from 0.50s limit to run CodeIgniter\\Database\\Live\\ConnectTest::testConnectWithFailover
{
$this->tests['failover'][] = $this->tests;
unset($this->tests['failover'][0]['failover']);
$this->model->update($id, []);
}
public function testUpdateObjectWithDataException(): void

Check warning on line 303 in tests/system/Models/UpdateModelTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.25s from 0.50s limit to run CodeIgniter\\Models\\UpdateModelTest::testUpdateObjectWithDataException
{
$this->createModel(EventModel::class);
return $this->model;
}
public function testValid(): void

Check warning on line 49 in tests/system/Models/ValidationModelRuleGroupTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.25s from 0.50s limit to run CodeIgniter\\Models\\ValidationModelRuleGroupTest::testValid
{
$data = [
'name' => 'some name',
$this->seeInDatabase('job', ['name' => 'Grocery Sales']);
}
public function testInsertBatch(): void

Check warning on line 50 in tests/system/Database/Live/InsertTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.17s from 0.50s limit to run CodeIgniter\\Database\\Live\\InsertTest::testInsertBatch
{
$table = 'type_test';
$this->createModel(UserModel::class)->insert([]);
}
public function testInsertPermitInsertNoData(): void

Check warning on line 237 in tests/system/Models/InsertModelTest.php

GitHub Actions / DatabaseLive (8.1, OCI8, 8.0) / tests

Took 1.08s from 0.50s limit to run CodeIgniter\\Models\\InsertModelTest::testInsertPermitInsertNoData
{
$forge = Database::forge();
$forge->addField([
$this->seeInDatabase('user', ['name' => $result->name]);
}
public function testCreateAddsCountToDatabase(): void

Check warning on line 44 in tests/system/Database/Live/FabricatorLiveTest.php

GitHub Actions / DatabaseLive (8.1, SQLite3, 8.0) / tests

Took 0.61s from 0.50s limit to run CodeIgniter\\Database\\Live\\FabricatorLiveTest::testCreateAddsCountToDatabase
{
$count = 10;