Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README #8548

Merged
merged 5 commits into from
Feb 17, 2024
Merged

docs: update README #8548

merged 5 commits into from
Feb 17, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 16, 2024

Description

  • minor updates

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

datamweb
datamweb reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a personal preference. I prefer to see the documents that have been Deployed through the codeigniter.com

admin/framework/README.md Outdated
@@ -11,8 +11,8 @@ It has been built from the

More information about the plans for version 4 can be found in [CodeIgniter 4](https://forum.codeigniter.com/forumdisplay.php?fid=28) on the forums.

The user guide corresponding to the latest version of the framework can be found
[here](https://codeigniter4.github.io/userguide/).
You can read the [user guide](https://codeigniter4.github.io/userguide/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can read the [user guide](https://codeigniter4.github.io/userguide/)
You can read the [user guide](https://codeigniter.com/user_guide/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

admin/starter/README.md Outdated
@@ -11,8 +11,8 @@ It has been built from the

More information about the plans for version 4 can be found in [CodeIgniter 4](https://forum.codeigniter.com/forumdisplay.php?fid=28) on the forums.

The user guide corresponding to the latest version of the framework can be found
[here](https://codeigniter4.github.io/userguide/).
You can read the [user guide](https://codeigniter4.github.io/userguide/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can read the [user guide](https://codeigniter4.github.io/userguide/)
You can read the [user guide](https://codeigniter.com/user_guide/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

datamweb
datamweb approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 342dd3a into codeigniter4:develop Feb 17, 2024
2 checks passed
@kenjis kenjis deleted the update-README branch February 17, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan