Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use word "UNIX timestamp" for consistency #8545

Merged
merged 1 commit into from
Feb 22, 2024
Merged

docs: use word "UNIX timestamp" for consistency #8545

merged 1 commit into from
Feb 22, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 14, 2024

Description

  • use word "UNIX timestamp" for consistency

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Feb 14, 2024
@paulbalandan
Copy link
Member

Where is the guidance for using UNIX? I'm also using "Unix".

@kenjis
Copy link
Member Author

kenjis commented Feb 14, 2024

Search the user guide. We use "UNIX timestamp" in other places. There is only one "Unix timestamp".

Maybe "Unix" is appropriate.

Unix (/ˈjuːnɪks/, YOO-niks; trademarked as UNIX)
https://en.wikipedia.org/wiki/Unix

@kenjis
Copy link
Member Author

kenjis commented Feb 22, 2024

Can someone approve?

@kenjis kenjis merged commit f7492e5 into codeigniter4:develop Feb 22, 2024
8 checks passed
@kenjis kenjis deleted the fix-word-UNIX-timestamp branch February 22, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @paulbalandan @lonnieezell