refactor: use ternary operators in Helpers #8529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Feb 9, 2024
kenjis
reviewed
Feb 9, 2024
kenjis
reviewed
Feb 9, 2024
|
I agree with @kenjis. I'm against micro-optimization that sacrifices the readability and maintainability of code. |
ddevsr
force-pushed
the
refactor-possible-oneliner
branch
from
c521ed7 to
11db748
Compare
kenjis
reviewed
Feb 10, 2024
system/Helpers/html_helper.php
Outdated
| . _list($type, $val, '', $depth + 4) | ||
| . str_repeat(' ', $depth + 2); | ||
| } | ||
| $out .= ! is_array($val) ? $val : $key . "\n" . _list($type, $val, '', $depth + 4) . str_repeat(' ', $depth + 2); |
kenjis
reviewed
Feb 10, 2024
system/Helpers/html_helper.php
Outdated
| } else { | ||
| $img .= ' src="' . slash_item('baseURL') . $src['src'] . '"'; | ||
| } | ||
| $img .= $indexPage === true ? ' src="' . site_url($src['src']) . '"' : ' src="' . slash_item('baseURL') . $src['src'] . '"'; |
kenjis
reviewed
Feb 10, 2024
system/Helpers/html_helper.php
Outdated
| } else { | ||
| $script .= 'src="' . slash_item('baseURL') . $v . '" '; | ||
| } | ||
| $script .= $indexPage === true ? 'src="' . site_url($v) . '" ' : 'src="' . slash_item('baseURL') . $v . '" '; |
kenjis
reviewed
Feb 10, 2024
system/Helpers/html_helper.php
Outdated
| } else { | ||
| $video .= ' src="' . slash_item('baseURL') . $src . '"'; | ||
| } | ||
| $video .= _has_protocol($src) ? ' src="' . $src . '"' : ($indexPage === true ? ' src="' . site_url($src) . '"' : ' src="' . slash_item('baseURL') . $src . '"'); |
kenjis
reviewed
Feb 10, 2024
system/Helpers/html_helper.php
Outdated
| } else { | ||
| $audio .= ' src="' . slash_item('baseURL') . $src . '"'; | ||
| } | ||
| $audio .= _has_protocol($src) ? ' src="' . $src . '"' : ($indexPage === true ? ' src="' . site_url($src) . '"' : ' src="' . slash_item('baseURL') . $src . '"'); |
kenjis
reviewed
Feb 10, 2024
system/Helpers/text_helper.php
Outdated
| } else { | ||
| $output .= $line . "\n"; | ||
| } | ||
| $output .= $temp !== '' ? $temp . "\n" . $line . "\n" : $line . "\n"; |
kenjis
reviewed
Feb 10, 2024
system/Helpers/text_helper.php
Outdated
| } else { | ||
| $end = mb_substr($str, -($maxLength - mb_strlen($beg))); | ||
| } | ||
| $end = $position === 1 ? mb_substr($str, 0, -($maxLength - mb_strlen($beg))) : mb_substr($str, -($maxLength - mb_strlen($beg))); |
kenjis
changed the title
Helper
michalsn
approved these changes
Feb 12, 2024
|
@ddevsr Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just refactor to one liner.
Checklist: