Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update description for 404 Override #8488

Merged
merged 2 commits into from
Jan 31, 2024
Merged

docs: update description for 404 Override #8488

merged 2 commits into from
Jan 31, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 31, 2024 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jan 31, 2024
@kenjis
docs: fix doc comments
60042fb 
I think there is no way to set 404 closure in the constructor.
@kenjis kenjis force-pushed the docs-update-404-override branch from 149045d to 60042fb Compare January 31, 2024 11:52
@kenjis kenjis merged commit c94e64a into codeigniter4:develop Jan 31, 2024
63 checks passed
@kenjis kenjis deleted the docs-update-404-override branch January 31, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb