Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update testInsertBatch() to use various data types #8450

Merged
merged 1 commit into from
Jan 25, 2024
Merged

test: update testInsertBatch() to use various data types #8450

merged 1 commit into from
Jan 25, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 24, 2024

Description

  • update test

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Jan 24, 2024
@kenjis kenjis mentioned this pull request Jan 25, 2024
Merged
5 tasks
sclubricants
sclubricants approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@sclubricants sclubricants left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kenjis kenjis merged commit 88547ad into codeigniter4:develop Jan 25, 2024
59 checks passed
@kenjis kenjis deleted the test-postgre-qb-InsertBatch branch January 25, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sclubricants sclubricants sclubricants approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @sclubricants