Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Email] setAttachmentCID() does not work with buffer string #8446

Merged
merged 2 commits into from
Jan 25, 2024
Merged

fix: [Email] setAttachmentCID() does not work with buffer string #8446

merged 2 commits into from
Jan 25, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 23, 2024

Description
Fixes #8419

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 23, 2024
@kenjis kenjis mentioned this pull request Jan 23, 2024
Closed
@kenjis kenjis merged commit ca7d92c into codeigniter4:develop Jan 25, 2024
62 checks passed
@kenjis kenjis deleted the fix-email-attach-cid branch January 25, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Email.php inline images fail.
2 participants
@kenjis @michalsn