Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5] test: update highlightFile test #8417

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 16, 2024

Description
Follow-up #8401

  • update expectations
  • remove test for PHP 7.4
  • add declare(strict_types=1);

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.5 testing Pull requests that changes tests only labels Jan 16, 2024
@kenjis kenjis changed the title test: update highlightFile expectations test: update highlightFile test Jan 16, 2024
@kenjis kenjis marked this pull request as draft January 16, 2024 05:52
@kenjis
Copy link
Member Author

kenjis commented Jan 16, 2024

@samsonasik 120 secs are not enough?

Run vendor/bin/rector process system --dry-run --no-progress-bar

Error: ] Could not process                                                      
         "/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/rector/rector/vendo
         r/symplify/easy-parallel/src/ValueObject/ParallelProcess.php" file, due
         to:                                                                    
         "Child process timed out after 120 seconds". On line: 108              

Error: ] Could not process some files, due to:                                  
         "Reached system errors count limit of 50, exiting...".                 

Error: Process completed with exit code 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7537591790/job/20516737923?pr=8417

@samsonasik
Copy link
Member

jobs may need to be configured:

$rectorConfig->parallel(120, 8, 15);

@samsonasik
Copy link
Member

Could you rebase develop, I updatedx parallel config

6f045bf

@kenjis kenjis force-pushed the update-highlightFile-tests branch from 25a2e05 to 798ac68 Compare January 16, 2024 07:10
@samsonasik
Copy link
Member

It seems working ok now 👍 , it shows Rector diff for declare strict types

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7538189545/job/20518317126?pr=8417#step:9:20

@kenjis kenjis changed the title test: update highlightFile test [4.5] test: update highlightFile test Jan 16, 2024
@kenjis kenjis marked this pull request as ready for review January 16, 2024 07:25
@kenjis
Copy link
Member Author

kenjis commented Jan 16, 2024

What's this error?
DatabaseLive (8.1, MySQLi, 8.0) / tests

Run actions/upload-artifact@v4
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7538341802/job/20518811849?pr=8417

@samsonasik
Copy link
Member

Probably similar with this reported issue, there is similar name actions/upload-artifact#481

@kenjis
Copy link
Member Author

kenjis commented Jan 16, 2024

Ah, DatabaseLive (8.1, MySQLi, 5.7) / tests already uploaded database-live-tests-php-8.1-db-MySQLi.

Run actions/upload-artifact@v4
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Uploaded bytes 8388608
Uploaded bytes 10336761
Finished uploading artifact content to blob storage!
SHA256 hash of uploaded artifact zip is e9164e2574eb47de3b160551eb24243ba66879ed617e499913a9a7cef84e5f34
Finalizing artifact upload
Artifact database-live-tests-php-8.1-db-MySQLi.zip successfully finalized. Artifact ID 1171525675
Artifact database-live-tests-php-8.1-db-MySQLi has been successfully uploaded! Final size is 10336761 bytes. Artifact ID is 1171525675
Artifact download URL: https://github.com/codeigniter4/CodeIgniter4/actions/runs/7538341802/artifacts/1171525675

https://github.com/codeigniter4/CodeIgniter4/actions/runs/7538341802/job/20518811643?pr=8417

@kenjis
Copy link
Member Author

kenjis commented Jan 16, 2024

Anyway, all tests were passed. Just Coverage upload was failed.
If anyone approves this, feel free to merge for fixing test failures in 4.5 branch.

I sent #8424 to fix the error.

@samsonasik samsonasik merged commit b28af1d into codeigniter4:4.5 Jan 16, 2024
44 of 45 checks passed
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the update-highlightFile-tests branch January 16, 2024 21:30
@kenjis kenjis mentioned this pull request Jan 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants