Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test php-cs-fixer after update to v3.47.0 #8415

Closed
wants to merge 3 commits into from

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jan 16, 2024

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr
Copy link
Collaborator Author

ddevsr commented Jan 16, 2024

binary_operator_space has changed by PHP-CS-Fixer/PHP-CS-Fixer#7593

@kenjis
Copy link
Member

kenjis commented Jan 16, 2024

This seems a bug in cs-fixer.
See PHP-CS-Fixer/PHP-CS-Fixer#7593 (comment)
PHP-CS-Fixer/PHP-CS-Fixer#7745

It may be better to fix cs-fix version to 3.46 temporarily.

@ddevsr
Copy link
Collaborator Author

ddevsr commented Jan 16, 2024

@kenjis Yes, i already create PR on CodeIgniter/coding-standard#16

@ddevsr ddevsr closed this Jan 16, 2024
@ddevsr ddevsr deleted the patch-1 branch January 16, 2024 02:58
@kenjis
Copy link
Member

kenjis commented Jan 16, 2024

It needs the new release of coding-standard.
I mean to fix in this repository.
See #8368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants