fix: [Validation] DotArrayFilter returns incorrect array when numeric index array is passed

[grimpirate]

Description
The use of array_merge_recursive rewrites numerically indexed values when attempting to retrieve validated data. Use of the array_merge_recursive_distinct function preserves their ordering. For an in-depth explanation and test harness.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Thank you for this PR!

But some GitHub Action checks are not successful.
Please update your code to pass all checks.

See

• https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style
• https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#static-analysis-on-php-code

Also we expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.
Please add test code in \CodeIgniter\Validation\DotArrayFilterTest https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/Validation/DotArrayFilterTest.php.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

[grimpirate]

I've provided a simplified unit test that fails when using array_merge_recursive but succeeds with the use of array_replace_recursive. Don't know that it covers every use case so if a more seasoned developer could consider the ramifications I would be appreciative. There appears to be a similar issue in Laravel.

[kenjis]

The first commit is completely removed. So squash the commits if you can.

[kenjis]

The GPG sign is missing. Please sign again.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

[grimpirate]

There's no GPG associated with my account.

[kenjis]

How did you sign the commits before squashing?

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

We cannot merge commits without signing. Thank you.

[grimpirate]

I made the changes directly on the github platform, but I couldn't squash the commits unless I did it locally.

[grimpirate]

I'll close this and open a new pull request without the squash.

[kenjis]

@grimpirate Okay, no problem.