Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug 4.4.4 spark serve not working when using Session in Routes.php #8389

Merged
merged 2 commits into from
Dec 30, 2023
+1 −1
Merged

fix: bug 4.4.4 spark serve not working when using Session in Routes.php #8389

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee4e4a
Fix bug 4.4.4 spark not working
ALTITUDE-DEV-FR Dec 30, 2023
6dda636
Update Session.php
ALTITUDE-DEV-FR Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/Session/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@
return $value;
}

if ($_SESSION === []) {
if (empty($_SESSION) || $_SESSION === []) {

Check failure on line 499 in system/Session/Session.php

View workflow job for this annotation

GitHub Actions / PHP Static Analysis 

Construct empty() is not allowed. Use more strict comparison.
samsonasik marked this conversation as resolved.
Show resolved Hide resolved
return $key === null ? [] : null;
}

Expand Down
Loading