Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: update coding style by php-cs-fixer v3.43.0 #8384

Merged
merged 4 commits into from
Dec 29, 2023
Merged

style: update coding style by php-cs-fixer v3.43.0 #8384

merged 4 commits into from
Dec 29, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 29, 2023 •
edited
Loading

Description
Follow-up #8368

  • update php-cs-fixer
  • update coding style

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Dec 29, 2023
@kenjis kenjis changed the title refactor: apply php-cs-fixer v3.43.0 style: update coding style by php-cs-fixer v3.43.0 Dec 29, 2023
@kenjis kenjis removed the refactor Pull requests that refactor code label Dec 29, 2023
michalsn
michalsn approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this apply to the devkit as well?

@kenjis kenjis merged commit e424098 into codeigniter4:develop Dec 29, 2023
63 checks passed
@kenjis kenjis deleted the update-cs-fixer-v3.43.0 branch December 29, 2023 08:48
@kenjis
Copy link
Member Author

kenjis commented Dec 29, 2023

This should apply to https://github.com/CodeIgniter/coding-standard

@paulbalandan
Copy link
Member

Added in CodeIgniter/coding-standard@5c11c9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @paulbalandan @michalsn