Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --dbgroup option to spark db:table #8292

Merged
merged 4 commits into from
Dec 9, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 4, 2023

Description
https://forum.codeigniter.com/showthread.php?tid=87978

$ ./spark db:table --show --dbgroup tests

CodeIgniter v4.4.3 Command Line Tool - Server Time: 2023-12-04 22:07:51 UTC+00:00

+-----------+----------+----------+----------+----------+------+
| hostname  | database | username | DBDriver | DBPrefix | port |
+-----------+----------+----------+----------+----------+------+
| 127.0.0.1 | ci4_test | root     | MySQLi   | db_      | 3306 |
+-----------+----------+----------+----------+----------+------+

The following is a list of the names of all database tables:

+----+---------------------------+-------------+---------------+
| ID | Table Name                | Num of Rows | Num of Fields |
+----+---------------------------+-------------+---------------+
| 1  | db_ci_sessions            | 1           | 4             |
| 2  | db_empty                  | 0           | 4             |
| 3  | db_ip_table               | 0           | 2             |
| 4  | db_job                    | 4           | 6             |
| 5  | db_migrations             | 1           | 7             |
| 6  | db_misc                   | 3           | 3             |
| 7  | db_secondary              | 0           | 3             |
| 8  | db_stringifypkey          | 1           | 2             |
| 9  | db_type_test              | 1           | 21            |
| 10 | db_user                   | 4           | 7             |
| 11 | db_uuid                   | 1           | 2             |
| 12 | db_without_auto_increment | 1           | 2             |
+----+---------------------------+-------------+---------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title feat: add spark `db table dbgroup feat: add dbgroup optiion to spark db:table Dec 4, 2023
@kenjis kenjis changed the title feat: add dbgroup optiion to spark db:table feat: add --dbgroup optiion to spark db:table Dec 4, 2023
@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Dec 4, 2023
@kenjis kenjis changed the title feat: add --dbgroup optiion to spark db:table feat: add --dbgroup option to spark db:table Dec 4, 2023
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature. Tests need to be passed.

@kenjis kenjis force-pushed the feat-spark-db-table-dbgroup branch from 759d1d8 to 367c5db Compare December 6, 2023 09:34
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition. I hadn't noticed before that we have such a command...

@kenjis kenjis merged commit 6c487a1 into codeigniter4:4.5 Dec 9, 2023
45 checks passed
@kenjis kenjis deleted the feat-spark-db-table-dbgroup branch December 9, 2023 01:08
@kenjis kenjis mentioned this pull request Dec 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants