-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: route key lowercase HTTP verbs #8235
Conversation
30b1c73
to
238905b
Compare
e4f32df
to
5e7c0a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does suppressing the trigger_error()
gives us?
I don't know. cs-fixer adds |
This allows it to be catched by the error handler and saved in the logs. |
It is NOT HTTP verb.
109ddc4
to
72f16ab
Compare
The error handler always catches the error. It changes the return value of --- a/system/Debug/Exceptions.php
+++ b/system/Debug/Exceptions.php
@@ -197,6 +197,8 @@ class Exceptions
*/
public function errorHandler(int $severity, string $message, ?string $file = null, ?int $line = null)
{
+ dd($severity, error_reporting());
+
if ($this->isDeprecationError($severity)) {
if (! $this->config->logDeprecations || (bool) env('CODEIGNITER_SCREAM_DEPRECATIONS')) {
throw new ErrorException($message, 0, $severity, $file, $line); With
Without
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, guys!
Description
Follow-up #8186
FeatureTestTrait::call()
Checklist: