Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FilterTestTrait Undefined variable $filterClasses #8195

Merged
merged 4 commits into from
Nov 18, 2023
Merged

fix: FilterTestTrait Undefined variable $filterClasses #8195

merged 4 commits into from
Nov 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 12, 2023 •
edited
Loading

Description
Fixes #8113
Follow-up #8058

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 12, 2023
@kenjis kenjis changed the title fix: FilterTestTrait Undefined Variable fix: FilterTestTrait Undefined variable $filterClasses Nov 12, 2023
@kenjis kenjis mentioned this pull request Nov 12, 2023
Merged
5 tasks
@kenjis kenjis marked this pull request as draft November 12, 2023 08:42
@kenjis kenjis force-pushed the fix-FilterTestTrait branch from 012cf3b to 0dc64cd Compare November 12, 2023 08:51
@kenjis kenjis marked this pull request as ready for review November 12, 2023 08:52
@kenjis kenjis requested a review from MGatner November 14, 2023 07:52
@kenjis kenjis merged commit d980e99 into codeigniter4:develop Nov 18, 2023
60 checks passed
@kenjis kenjis deleted the fix-FilterTestTrait branch November 18, 2023 23:52
@MGatner
Copy link
Member

MGatner commented Nov 19, 2023

Thanks @kenjis - this was still on my list to get to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner Awaiting requested review from MGatner

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: FilterTestTrait Undefined Variable
3 participants
@kenjis @MGatner @michalsn