feat: Validation::run() accepts DB connection

[ciadavid]

Description
See #6723

Remove on run() $dbGroup ?string because it can allow group array connections, not only dgGroup Name.

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

This is a breaking change.
See https://3v4l.org/VMDWp

[kenjis]

For this PR to be merged, it is necessary to have at least the following:

• Change the destination of the PR to the next minor version branch (4.5 at the time of writing) instead of develop
• Add explanations to the changelog and upgrading guide regarding the breaking change
• Add test code for the added functionality

If you have any question, feel free to ask.

[lonnieezell]

I see nothing wrong with the intention of this PR, and I don't really find it to be a BC break, since it's opening up new capabilities not restricting. As mentioned, we would need tests added and the interface would also need to be updated.

@ciadavid Are you able to tackle this? If not, we'll go ahead and close this.

[ciadavid]

how can I write a test?

//DB conection array
$conection_array = array(
	'hostname' => 'localhost',
	'username' => 'user',
	'password' => 'pass',
	'database' => 'database',
	'DBDriver' => 'MySQLi',
	'port'     => 3306,	
);

//Default config
//File /Config/Databse.php 'default' the same as $conection_array

//Create table users whit field name unique

$validation_rule = array(
	'Name' => 'required|is_not_unique[users.name,Name]',
);

//Whit interface updated.

$validation = \Config\Services::validation();
$validation->setRules($validation_rule);
$isValid = $validation->run(array('Name' => 'John Doe'),null,$conection_array);

$isValid = $validation->run(array('Name' => ''),null,'default');

//Both are working whitout errors.

//Whit interface not updated.
$isValid = $validation->run(array('Name' => 'John Doe'),null,$conection_array); ///Error third parameter must be an string beacuse is only allower to use the connection string name.


/**
 * Runs the validation process, returning true/false determining whether
	 * validation was successful or not.
	 *
	 * @param array|null  $data    The array of data to validate.
	 * @param string|null $group   The predefined group of rules to apply.
	 * @param string|null $dbGroup The database group to use.
 */
// public function run(?array $data = null, ?string $group = null, $dbGroup = null): bool;

// When is_unique rule is used, it tray co connect to dabase, here is allowed to use the connection string name or an array with the connection data.
/*
	public function is_not_unique(?string $str, string $field, array $data): bool
	{
		// Grab any data for exclusion of a single row.
		[$field, $whereField, $whereValue] = array_pad(
			explode(',', $field),
			3,
			null
		);
		// Break the table and field apart
		sscanf($field, '%[^.].%[^.]', $table, $field);

		$row = Database::connect($data['DBGroup'] ?? null)
			->table($table)
			->select('1')
			->where($field, $str)
			->limit(1);
		if (! empty($whereField) && ! empty($whereValue)
					&& ! preg_match('/^\{(\w+)\}$/', $whereValue)
		) {
			$row = $row->where($whereField, $whereValue);
		}

		return $row->get()->getRow() !== null;
	}

the Database::connect($data['DBGroup'] ?? null) allow to send array whit database connection or the group name.

*/

[kenjis]

@lonnieezell The intention of this PR is not wrong.
But see https://3v4l.org/VMDWp
If a dev overrides Validation::run(), it will break, because of Fatal error.
So according our current policy, it is a breaking change.

Therefore we don't accept this change in develop branch.
This must go to 4.5 branch.

[kenjis]

@ciadavid Have you ever written test code?
If you are not familiar with testing, see https://github.com/codeigniter4/CodeIgniter4/tree/develop/tests#resources

This is the test class for Database Related Rules Test:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/tests/system/Validation/StrictRules/DatabaseRelatedRulesTest.php

[kenjis]

@ciadavid This PR must go to 4.5 branch, not develop.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

[kenjis]

I sent another PR #8499

[kenjis]

Closed by #8499