Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add PHPDoc types to Model for PHPStan #8187

Merged
merged 2 commits into from
Nov 21, 2023
Merged

docs: add PHPDoc types to Model for PHPStan #8187

merged 2 commits into from
Nov 21, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 10, 2023

Description

  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title docs: add PHPDoc types for PHPStan docs: add PHPDoc types to Model for PHPStan Nov 10, 2023
@kenjis kenjis force-pushed the docs-Model-phpdoc-types branch from a3ecb99 to 7675798 Compare November 14, 2023 22:12
@kenjis
Copy link
Member Author

kenjis commented Nov 14, 2023

Changed to snake_case. See #8211

@kenjis kenjis mentioned this pull request Nov 19, 2023
Closed
MGatner
MGatner approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but let's get @paulbalandan to sign off on it as well.

@kenjis kenjis requested a review from paulbalandan November 20, 2023 21:21
@kenjis kenjis merged commit 8b9529f into codeigniter4:develop Nov 21, 2023
60 checks passed
@kenjis kenjis deleted the docs-Model-phpdoc-types branch November 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan