Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Use assertEqualsWithDelta() when possible #8158

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Testing] Use assertEqualsWithDelta() when possible #8158

merged 1 commit into from
Nov 7, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 6, 2023 •
edited by kenjis
Loading

Description

Run latest rector dev-main to apply assertEqualsWithDelta() when possible.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Rebased 👍

@samsonasik
Copy link
Member Author

psalm notice seems unrelated

kenjis
kenjis approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis added the testing Pull requests that changes tests only label Nov 7, 2023
@samsonasik samsonasik merged commit f6fabae into codeigniter4:develop Nov 7, 2023
56 of 57 checks passed
@samsonasik samsonasik deleted the rector-run-dev-main branch November 7, 2023 04:52
@samsonasik
Copy link
Member Author

@kenjis thank you for the review

MGatner
MGatner reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

PHP_FLOAT_EPSILON (float)
Smallest representable positive number x, so that x + 1.0 != 1.0. Available as of PHP 7.2.0.

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner left review comments

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @kenjis @MGatner