Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve view_cells.rst #8132

Merged
merged 5 commits into from
Nov 1, 2023
Merged

docs: improve view_cells.rst #8132

merged 5 commits into from
Nov 1, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 1, 2023

Description
See #8121

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 1, 2023
@kenjis kenjis mentioned this pull request Nov 1, 2023
Closed
michalsn
michalsn reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if my suggestion sounds clear or not... maybe there is a better wording.

user_guide_src/source/outgoing/view_cells.rst Outdated Show resolved Hide resolved
@kenjis @michalsn
docs: fix incorrect description
b0534cc 
Co-authored-by: Michal Sniatala <[email protected]>
@kenjis kenjis merged commit 71f3e00 into codeigniter4:develop Nov 1, 2023
7 checks passed
@kenjis kenjis deleted the docs-view_cells.rst branch November 1, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn