Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use native PHPDocs instead of @phpstan- #8114

Merged
merged 1 commit into from
Oct 30, 2023
Merged

docs: Use native PHPDocs instead of @phpstan- #8114

merged 1 commit into from
Oct 30, 2023

Conversation

paulbalandan
Copy link
Member

Description
Exceptions are:

  • literal strings
  • conditional returns
  • generic templates

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan mentioned this pull request Oct 28, 2023
Merged
5 tasks
kenjis
kenjis reviewed Oct 29, 2023
View reviewed changes
system/HTTP/CLIRequest.php Outdated Show resolved Hide resolved
@kenjis kenjis merged commit 6c06f84 into codeigniter4:develop Oct 30, 2023
60 checks passed
@kenjis
Copy link
Member

kenjis commented Oct 30, 2023

@paulbalandan Thank you!

@paulbalandan paulbalandan deleted the phpstan-phpdocs branch October 30, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @kenjis