Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate CodeIgniter::displayCache() param #8030

Merged
merged 3 commits into from
Oct 13, 2023
Merged

docs: deprecate CodeIgniter::displayCache() param #8030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e96187
docs: deprecate unused param $config
kenjis Oct 11, 2023
ae7edbd
docs: fix typos in comments
kenjis Oct 11, 2023
f8015f1
docs: add changelog
kenjis Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions system/CodeIgniter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ private function configureKint(): void
* This is "the loop" if you will. The main entry point into the script
* that gets the required class instances, fires off the filters,
* tries to route the response, loads the controller and generally
* makes all of the pieces work together.
* makes all the pieces work together.
*
* @return ResponseInterface|void
*/
Expand Down Expand Up @@ -703,6 +703,8 @@ protected function forceSecureAccess($duration = 31_536_000)
* @return false|ResponseInterface
*
* @throws Exception
*
* @deprecated 4.4.2 The parameter $config is deprecated. No longer used.
*/
public function displayCache(Cache $config)
{
Expand All @@ -722,7 +724,7 @@ public function displayCache(Cache $config)
/**
* Tells the app that the final output should be cached.
*
* @deprecated 4.4.0 Moved to ResponseCache::setTtl(). to No longer used.
* @deprecated 4.4.0 Moved to ResponseCache::setTtl(). No longer used.
*
* @return void
*/
Expand Down Expand Up @@ -794,7 +796,7 @@ public function displayPerformanceMetrics(string $output): string
* match a route against the current URI. If the route is a
* "redirect route", will also handle the redirect.
*
* @param RouteCollectionInterface|null $routes An collection interface to use in place
* @param RouteCollectionInterface|null $routes A collection interface to use in place
* of the config file.
*
* @return string|string[]|null Route filters, that is, the filters specified in the routes file
Expand Down
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.4.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ Deprecations
details.
- **CLI:** The public property ``CLI::$readline_support`` and ``CLI::$wait_msg``
are deprecated. These methods will be protected.
- **CodeIgniter:** The parameter ``$config`` for the ``displayCache()`` method is
deprecated. It was not used.

Bugs Fixed
**********
Expand Down
Loading