Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CSP style nonce is added even if honeypot is not attached #8025

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix: CSP style nonce is added even if honeypot is not attached #8025

merged 2 commits into from
Oct 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 10, 2023 •
edited
Loading

Description
Fixes #8020
See #8020 (comment)

The tag like this was added before </head> tag in every page.

<style nonce="ccdd15247e8da0a5b9023a5e">#hpc { display:none }</style>

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 10, 2023
@kenjis kenjis mentioned this pull request Oct 10, 2023
Closed
kenjis added 2 commits October 10, 2023 16:50
@kenjis
test: add test
a9cd190
@kenjis
fix: CSP style nonce is added even if honeypot is not attached
4892849 
The tag like this was added in <head> tag in every page.
<style nonce="ccdd15247e8da0a5b9023a5e">#hpc { display:none }</style>
@kenjis kenjis force-pushed the fix-Honeypot-CSP-style-nonce branch from 4b3dc87 to 4892849 Compare October 10, 2023 07:51
MGatner
MGatner approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@kenjis kenjis merged commit 617180a into codeigniter4:develop Oct 13, 2023
60 checks passed
@kenjis kenjis deleted the fix-Honeypot-CSP-style-nonce branch October 13, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HoneyPot CSS Style nonce (when using CSP) does not work with Web Page Caching
3 participants
@kenjis @michalsn @MGatner