Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rely on $config property in ViewDecoratorTrait #8021

Merged
merged 3 commits into from
Dec 26, 2023
Merged

refactor: rely on $config property in ViewDecoratorTrait #8021

merged 3 commits into from
Dec 26, 2023

Conversation

mostafakhudair
Copy link
Contributor

Use View::$config instead of config() function

@mostafakhudair
refactor: ViewDecoratorTrait
67f8876 
Use `View::$config` instead of  `config()` function
@mostafakhudair mostafakhudair changed the title refactor: ViewDecoratorTrait refactor: rely on $config property in ViewDecoratorTrait Oct 9, 2023
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 9, 2023
MGatner
MGatner requested changes Oct 12, 2023
View reviewed changes
system/View/ViewDecoratorTrait.php Outdated Show resolved Hide resolved
kenjis
kenjis requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix UndefinedClass error.

MGatner
MGatner requested changes Dec 19, 2023
View reviewed changes
system/View/ViewDecoratorTrait.php Outdated Show resolved Hide resolved
@kenjis kenjis merged commit 54d188b into codeigniter4:develop Dec 26, 2023
61 checks passed
@kenjis
Copy link
Member

kenjis commented Dec 26, 2023

@mostafakhudair Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell left review comments

@MGatner MGatner MGatner requested changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mostafakhudair @kenjis @lonnieezell @MGatner