-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: replace $locator->getClassname() with findQualifiedNameFromPath() #8012
perf: replace $locator->getClassname() with findQualifiedNameFromPath() #8012
Conversation
MINGW64 /e/www/ci-demo (dev)
$ php -v
PHP 8.2.11 (cli) (built: Sep 26 2023 15:25:31) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.11, Copyright (c) Zend Technologies Performance has not changed (my project) |
See my results. The change is only about 0.5MB. |
I tried my test project. Used mem ~7.5 - 7.6 with pagination, filters, events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; awaiting rebase.
83566ae
to
d3b5c17
Compare
The difference is not as great as before.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeIgniter's niche is being a full-featured monolith framework that is conservative on magic and very lightweight and easy to install. I think anything that keeps our performance impact down will only help the marketing.
Needs #8010Description
To be honest, I am not sure if the speed has increased, but memory consumption has definitely decreased.
Welcome page:
Before:
After:
macOS 12.7
Checklist: