feat: add {memory_usage} replacement
#8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
force-pushed
the
add-memory-usage-in-welcome
branch
2 times, most recently
from
c034e89 to
0294152
Compare
kenjis
changed the title
{memory_usage} replacement
michalsn
approved these changes
Oct 8, 2023
kenjis
force-pushed
the
add-memory-usage-in-welcome
branch
from
0294152 to
3653d74
Compare
|
Added changelog. |
ddevsr
approved these changes
Oct 9, 2023
MGatner
approved these changes
Oct 10, 2023
| */ | ||
| public function displayPerformanceMetrics(string $output): string | ||
| { | ||
| return str_replace('{elapsed_time}', (string) $this->totalTime, $output); | ||
| return str_replace( |
There was a problem hiding this comment.
This should probably be an after Filter at some point on the Welcome route - no business being in the main app class.
There was a problem hiding this comment.
Yes, I thought the same thing.
And probably Web Page Caching also should be a filter.
kenjis
force-pushed
the
add-memory-usage-in-welcome
branch
from
3653d74 to
f515488
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's useful when benchmarking in production mode.
{memory_usage}replacementChecklist: