Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on Config\Kint with Config Caching #8003

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: error on Config\Kint with Config Caching #8003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c18a661
fix: Config\Kint does not extend BaseConfig
kenjis Oct 4, 2023
ff2c6b6
docs: add upgrade_450
kenjis Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/Config/Kint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Config;

use CodeIgniter\Config\BaseConfig;
use Kint\Parser\ConstructablePluginInterface;
use Kint\Renderer\AbstractRenderer;
use Kint\Renderer\Rich\TabPluginInterface;
Expand All @@ -18,7 +17,7 @@
*
* @see https://kint-php.github.io/kint/ for details on these settings.
*/
class Kint extends BaseConfig
class Kint
{
/*
|--------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion system/CodeIgniter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ private function autoloadKint(): void

private function configureKint(): void
{
$config = config(KintConfig::class);
$config = new KintConfig();

Kint::$depth_limit = $config->maxDepth;
Kint::$display_called_from = $config->displayCalledFrom;
Expand Down
3 changes: 3 additions & 0 deletions user_guide_src/source/installation/upgrade_450.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ Config
- app/Config/Feature.php
- ``Config\Feature::$multipleFilters`` has been removed, because now
:ref:`multiple-filters` are always enabled.
- app/Config/Kint.php
- It no longer extends ``BaseConfig`` because enabling
:ref:`factories-config-caching` could cause errors.

All Changes
===========
Expand Down
Loading