Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the testcase error on MariaDB. #7989

Merged
merged 2 commits into from
Oct 1, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/Database/Live/ForgeTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
parent::setUp();
}

public function testCreateDatabase(): void

Check warning on line 50 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.58s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabase
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
Expand All @@ -57,7 +57,7 @@
$this->assertTrue($databaseCreated);
}

public function testCreateDatabaseIfNotExists(): void

Check warning on line 60 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.65s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabaseIfNotExists
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
Expand All @@ -72,7 +72,7 @@
$this->assertTrue($databaseCreateIfNotExists);
}

public function testCreateDatabaseIfNotExistsWithDb(): void

Check warning on line 75 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.61s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabaseIfNotExistsWithDb
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
Expand Down Expand Up @@ -384,7 +384,7 @@
$this->forge->createTable('forge_test_table');
}

public function testRenameTable(): void

Check warning on line 387 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.73s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testRenameTable
{
$this->forge->dropTable('forge_test_table_dummy', true);

Expand Down Expand Up @@ -440,7 +440,7 @@
$this->forge->dropTable('', true);
}

public function testForeignKey(): void

Check warning on line 443 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 5.66s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testForeignKey

Check warning on line 443 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.72s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
Expand Down Expand Up @@ -544,7 +544,7 @@
/**
* @see https://github.com/codeigniter4/CodeIgniter4/issues/4310
*/
public function testCompositeForeignKey(): void

Check warning on line 547 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.58s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCompositeForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
Expand Down Expand Up @@ -730,7 +730,7 @@
$this->forge->createTable('forge_test_invoices', true, $attributes);
}

public function testDropForeignKey(): void

Check warning on line 733 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.71s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
Expand Down Expand Up @@ -941,7 +941,7 @@
],
];

if (version_compare($this->db->getVersion(), '8.0.17', '>=')) {
if (version_compare($this->db->getVersion(), '8.0.17', '>=') && str_contains($this->db->getVersion(), 'MariaDB') === false) {
paulbalandan marked this conversation as resolved.
Show resolved Hide resolved
// As of MySQL 8.0.17, the display width attribute for integer data types
// is deprecated and is not reported back anymore.
// @see https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html
Expand Down Expand Up @@ -1087,7 +1087,7 @@
$this->assertSame($expected, json_decode(json_encode($fieldsData), true));
}

public function testCompositeKey(): void

Check warning on line 1090 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.63s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCompositeKey
{
$this->forge->dropTable('forge_test_1', true);

Expand Down Expand Up @@ -1182,7 +1182,7 @@
$this->forge->dropTable('forge_test_1', true);
}

public function testSetKeyNames(): void

Check warning on line 1185 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 2.57s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testSetKeyNames
{
$this->forge->dropTable('forge_test_1', true);

Expand Down Expand Up @@ -1318,7 +1318,7 @@
$this->forge->dropTable('forge_test_three', true);
}

public function testModifyColumnNullTrue(): void

Check warning on line 1321 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.60s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testModifyColumnNullTrue
{
$this->forge->dropTable('forge_test_modify', true);

Expand Down Expand Up @@ -1506,7 +1506,7 @@
$this->forge->dropTable('forge_test_four', true);
}

public function testDropKey(): void

Check warning on line 1509 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 2.12s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropKey
{
$this->forge->dropTable('key_test_users', true);
$keyName = 'key_test_users_id';
Expand Down Expand Up @@ -1593,7 +1593,7 @@
$this->forge->dropTable('forge_test_users', true);
}

public function testProcessIndexes(): void

Check warning on line 1596 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 3.11s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes

Check warning on line 1596 in tests/system/Database/Live/ForgeTest.php

View workflow job for this annotation

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.70s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes
{
// make sure tables don't exist
$this->forge->dropTable('actions', true);
Expand Down
Loading