Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [CLI] make public properties deprecated #7976

Merged
merged 2 commits into from
Oct 11, 2023
Merged

docs: [CLI] make public properties deprecated #7976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c5ff8d
docs: make public properties deprecated
kenjis Sep 25, 2023
dc84d18
docs: add @TODO to rename
kenjis Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions system/CLI/CLI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,19 @@ class CLI
* Is the readline library on the system?
*
* @var bool
*
* @deprecated 4.4.2 Should be protected.
* @TODO Fix to camelCase in the next major version.
*/
public static $readline_support = false;

/**
* The message displayed at prompts.
*
* @var string
*
* @deprecated 4.4.2 Should be protected.
* @TODO Fix to camelCase in the next major version.
*/
public static $wait_msg = 'Press any key to continue...';

Expand All @@ -63,6 +69,8 @@ class CLI
* Foreground color list
*
* @var array<string, string>
*
* @TODO Fix to camelCase in the next major version.
*/
protected static $foreground_colors = [
'black' => '0;30',
Expand All @@ -88,6 +96,8 @@ class CLI
* Background color list
*
* @var array<string, string>
*
* @TODO Fix to camelCase in the next major version.
*/
protected static $background_colors = [
'black' => '40',
Expand Down
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.4.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Deprecations
- **Filters:** The Auto-Discovery for Filters and ``Filters::discoverFilters()``
is deprecated. Use :ref:`registrars` instead. See :ref:`modules-filters` for
details.
- **CLI:** The public property ``CLI::$readline_support`` and ``CLI::$wait_msg``
are deprecated. These methods will be protected.

Bugs Fixed
**********
Expand Down
Loading