Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spark may not show exceptions or show backtrace as json #7962

Merged
merged 2 commits into from
Oct 10, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: add changelog
kenjis committed Oct 8, 2023

Verified

This commit was signed with the committer’s verified signature.
kenjis kenjis
commit b201fafb8373df2e92f1201180b5ed7eadf0ddb1
2 changes: 2 additions & 0 deletions user_guide_src/source/changelogs/v4.4.2.rst
Original file line number Diff line number Diff line change
@@ -34,6 +34,8 @@ Bugs Fixed

- **CodeIgniter:** Fixed a bug that returned "200 OK" response status code when
Page Not Found.
- **Spark:** Fixed a bug that caused spark to not display exceptions in the
production mode or to display backtrace in json when an exception occurred.

See the repo's
`CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_

Unchanged files with check annotations Beta

$this->assertSame(exif_imagetype($this->root . 'ci-logo.png'), IMAGETYPE_PNG);
}
public function testImageReorientLandscape(): void

Check warning on line 410 in tests/system/Images/ImageMagickHandlerTest.php

GitHub Actions / sanity-tests (8.1) / Sanity Tests

Took 0.65s from 0.50s limit to run CodeIgniter\\Images\\ImageMagickHandlerTest::testImageReorientLandscape
{
for ($i = 0; $i <= 8; $i++) {
$source = $this->origin . 'EXIFsamples/landscape_' . $i . '.jpg';
}
}
public function testImageReorientPortrait(): void

Check warning on line 429 in tests/system/Images/ImageMagickHandlerTest.php

GitHub Actions / sanity-tests (8.1) / Sanity Tests

Took 0.63s from 0.50s limit to run CodeIgniter\\Images\\ImageMagickHandlerTest::testImageReorientPortrait
{
for ($i = 0; $i <= 8; $i++) {
$source = $this->origin . 'EXIFsamples/portrait_' . $i . '.jpg';
parent::setUp();
}
public function testCreateDatabase(): void

Check warning on line 50 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.66s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabase
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
$this->assertTrue($databaseCreated);
}
public function testCreateDatabaseIfNotExists(): void

Check warning on line 60 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.73s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabaseIfNotExists
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
$this->assertTrue($databaseCreateIfNotExists);
}
public function testCreateDatabaseIfNotExistsWithDb(): void

Check warning on line 75 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.72s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCreateDatabaseIfNotExistsWithDb
{
if ($this->db->DBDriver === 'OCI8') {
$this->markTestSkipped('OCI8 does not support create database.');
$this->forge->createTable('forge_test_table');
}
public function testRenameTable(): void

Check warning on line 387 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.82s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testRenameTable
{
$this->forge->dropTable('forge_test_table_dummy', true);
$this->forge->dropTable('', true);
}
public function testForeignKey(): void

Check warning on line 443 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 3.69s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testForeignKey

Check warning on line 443 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.79s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
/**
* @see https://github.com/codeigniter4/CodeIgniter4/issues/4310
*/
public function testCompositeForeignKey(): void

Check warning on line 547 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.67s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testCompositeForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
$this->forge->createTable('forge_test_invoices', true, $attributes);
}
public function testDropForeignKey(): void

Check warning on line 733 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.83s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropForeignKey
{
$this->forge->dropTable('forge_test_invoices', true);
$this->forge->dropTable('forge_test_users', true);
$this->forge->dropTable('forge_test_1', true);
}
public function testSetKeyNames(): void

Check warning on line 1185 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.65s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testSetKeyNames
{
$this->forge->dropTable('forge_test_1', true);
$this->forge->dropTable('forge_test_two', true);
}
public function testModifyColumnRename(): void

Check warning on line 1281 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.74s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testModifyColumnRename
{
$this->forge->dropTable('forge_test_three', true);
$this->forge->dropTable('forge_test_three', true);
}
public function testModifyColumnNullTrue(): void

Check warning on line 1321 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.69s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testModifyColumnNullTrue
{
$this->forge->dropTable('forge_test_modify', true);
$this->forge->dropTable('forge_test_four', true);
}
public function testDropKey(): void

Check warning on line 1509 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.42s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testDropKey
{
$this->forge->dropTable('key_test_users', true);
$keyName = 'key_test_users_id';
$this->forge->dropTable('forge_test_users', true);
}
public function testProcessIndexes(): void

Check warning on line 1596 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 2.12s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes

Check warning on line 1596 in tests/system/Database/Live/ForgeTest.php

GitHub Actions / database-live-tests (8.1, SQLSRV, 5.7) / Database Live Tests

Took 0.81s from 0.50s limit to run CodeIgniter\\Database\\Live\\ForgeTest::testProcessIndexes
{
// make sure tables don't exist
$this->forge->dropTable('actions', true);
$this->assertSame($expected, $result);
}
public function testMigrateWithWithTwoNamespaces(): void

Check warning on line 97 in tests/system/Commands/Database/MigrateStatusTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 2.10s from 0.50s limit to run CodeIgniter\\Commands\\Database\\MigrateStatusTest::testMigrateWithWithTwoNamespaces
{
command('migrate -n App');
command('migrate -n Tests\\\\Support');
$this->assertSame('MySQLi', $this->getPrivateProperty($db1, 'DBDriver'));
}
public function testConnectWithFailover(): void

Check warning on line 95 in tests/system/Database/Live/ConnectTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.47s from 0.50s limit to run CodeIgniter\\Database\\Live\\ConnectTest::testConnectWithFailover
{
$this->tests['failover'][] = $this->tests;
unset($this->tests['failover'][0]['failover']);
$this->seeInDatabase('job', ['name' => 'Grocery Sales']);
}
public function testInsertBatch(): void

Check warning on line 50 in tests/system/Database/Live/InsertTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.36s from 0.50s limit to run CodeIgniter\\Database\\Live\\InsertTest::testInsertBatch
{
$jobData = [
[
$this->createModel(UserModel::class)->insert([]);
}
public function testInsertPermitInsertNoData(): void

Check warning on line 237 in tests/system/Models/InsertModelTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.31s from 0.50s limit to run CodeIgniter\\Models\\InsertModelTest::testInsertPermitInsertNoData
{
$forge = Database::forge();
$forge->addField([
$this->assertTrue($this->model->save($entity));
}
public function testSaveNewEntityWithDate(): void

Check warning on line 250 in tests/system/Models/SaveModelTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.24s from 0.50s limit to run CodeIgniter\\Models\\SaveModelTest::testSaveNewEntityWithDate
{
$entity = new class () extends Entity {
protected $id;
$this->dontSeeInDatabase('user', ['email' => 'ahmadinejad@world.com', 'name' => 'Ahmadinejad']);
}
public function testDeleteBatchWithQuery(): void

Check warning on line 101 in tests/system/Database/Live/DeleteTest.php

GitHub Actions / database-live-tests (8.1, OCI8, 5.7) / Database Live Tests

Took 1.22s from 0.50s limit to run CodeIgniter\\Database\\Live\\DeleteTest::testDeleteBatchWithQuery
{
$this->forge = Database::forge($this->DBGroup);