[Reverted] GitHub Actions to add/remove label "stale" and comment #7950
Conversation
totoprayogo1916
changed the title
totoprayogo1916
force-pushed
the
confl
branch
from
7213379 to
91dea0f
Compare
totoprayogo1916
force-pushed
the
confl
branch
from
91dea0f to
f188a75
Compare
|
This workflow labeled for PRs with no conflicts, so I reverted. |
| labels=$(echo "$pr" | jq -c '.labels[].name' | tr -d '[]"') | ||
| url=$(echo "$pr" | jq -r '.url') | ||
|
|
||
| if [ "$mergeable" != "MERGEABLE" ] && [[ ! "$labels" == *"stale"* ]]; then |
There was a problem hiding this comment.
@kenjis I believe the outcome of $mergeable yields an "UNKNOWN" result. Upon investigation, I discovered that $mergeable can result in three potential outcomes: "MERGEABLE," "CONFLICTING," or "UNKNOWN."
There was a problem hiding this comment.
Perhaps we could organize it in a way where "CONFLICTING" results take precedence.
There was a problem hiding this comment.
But if it is "UNKNOWN", we cannot put a label.
At least, I can see the outcomes:
$ gh pr list -L 100 --json mergeable,url
[
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7951"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7947"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7946"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7944"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7933"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7925"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7924"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7846"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7732"
},
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7724"
},
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7718"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7717"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7491"
},
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/7404"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/6877"
},
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/6845"
},
{
"mergeable": "CONFLICTING",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/6284"
},
{
"mergeable": "MERGEABLE",
"url": "https://github.com/codeigniter4/CodeIgniter4/pull/1797"
}
]
There was a problem hiding this comment.
Maybe it can be changed like this?
if [ "$mergeable" == "CONFLICTING" ] &&[[ ! "$labels" == *"stale"* ]]; then
...There was a problem hiding this comment.
The team point out that the merge state needs to be recalculated when the base branch changes. Since the
codeignitierPR is based on theirdevelopbranch (https://github.com/codeigniter4/CodeIgniter4/tree/develop), it would make sense that there are periods of time where a PRmergeablefield isUNKNOWN.I hope this answers your question 🙏
got the answer, why UNKNOWN on $mergeable
cli/cli#8020 (reply in thread)
There was a problem hiding this comment.
Thanks. Can you send another PR with "$mergeable" == "CONFLICTING"?
There was a problem hiding this comment.
created #7957
kenjis
changed the title
Description
GA concept:
Live Test: https://github.com/totoprayogo1916/github-playground/pull/13
Checklist: