Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't ignore .gitkeep in writable/debugbar #7937

Merged
merged 1 commit into from
Sep 14, 2023
Merged

don't ignore .gitkeep in writable/debugbar #7937

merged 1 commit into from
Sep 14, 2023

Conversation

totoprayogo1916
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 commented Sep 13, 2023 •
edited
Loading

Description
.gitkeep ignored in framework and appstarter.
This should not be ignored in writable/debugbar.

Checklist:

  • Securely signed commits

@totoprayogo1916 totoprayogo1916 changed the title don't ignore .gitkeep don't ignore .gitkeep in writable/debugbar Sep 13, 2023
MGatner
MGatner approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch.

@kenjis kenjis merged commit 6782b03 into codeigniter4:develop Sep 14, 2023
1 check passed
@kenjis
Copy link
Member

kenjis commented Sep 14, 2023

@totoprayogo1916 Thank you!

@totoprayogo1916 totoprayogo1916 deleted the dont-ignore-gitkeep branch September 14, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@totoprayogo1916 @kenjis @MGatner