Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [PHPStan] enable matchingInheritedMethodNames #7927

Merged
merged 1 commit into from
Sep 12, 2023
Merged

chore: [PHPStan] enable matchingInheritedMethodNames #7927

merged 1 commit into from
Sep 12, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 11, 2023 •
edited
Loading

Description
We already follow the rule.
See https://github.com/phpstan/phpstan-strict-rules/blob/1.5.x/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php

Ref #7916

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis merged commit 987667a into codeigniter4:develop Sep 12, 2023
9 checks passed
@kenjis kenjis deleted the phpstan-add-matchingInheritedMethodNames branch September 12, 2023 20:43
@kenjis kenjis changed the title chore: add PHPStan matchingInheritedMethodNames rule chore: [PHPStan] enable matchingInheritedMethodNames Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan