Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverse routing causes ErrorException #7880

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 30, 2023

Description
Fixes #7237
Fixes #7876

Fix the error "preg_match(): Compilation failed: missing closing parenthesis" when defining a route with nested parentheses.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis added 2 commits August 30, 2023 11:12
ErrorException : preg_match(): Compilation failed: missing closing parenthesis
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 30, 2023
@kenjis kenjis merged commit ed5d07e into codeigniter4:develop Sep 4, 2023
@kenjis kenjis deleted the fix-reverse-route-nested-parentheses branch September 4, 2023 20:29
@kenjis
Copy link
Member Author

kenjis commented Sep 4, 2023

@samsonasik Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
2 participants