docs: replace type mixed in DB Utils #7870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
system/Database/BaseUtils.php
Outdated
Comment on lines
263
to
264
| * @return false|string|void | ||
| * @phpstan-return false|string|never |
There was a problem hiding this comment.
Can be changed to never for native return?
There was a problem hiding this comment.
Do you mean @return false|never|string?
system/Database/MySQLi/Utils.php
Outdated
Comment on lines
39
to
40
| * @return void | ||
| * @phpstan-return never |
There was a problem hiding this comment.
Can be never for native return
kenjis
force-pushed
the
docs-replace-mixed-in-db-utils
branch
from
6e2140a to
036a0a8
Compare
|
Can someone review? |
paulbalandan
approved these changes
Sep 8, 2023
|
No problem. Thank you for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #6310
Checklist: