fix: Factories may not return shared instance #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the request class is the same, it is better to return the shared instance.
If it is called by different aliase like `'App'` and `App::class`. But if they are exactly the same FQCN, the shared instance should be returned.
kenjis
added
bug
This is more intuitive.
Because locateClass() already checks it.
kenjis
force-pushed
the
fix-factories-return-new-instance
branch
from
8b98540 to
1b88479
Compare
paulbalandan
approved these changes
Aug 27, 2023
datamweb
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you call
config(AuthJWT::class)(FQCN) and after that, callconfig('AuthJWT')(shortname),the new instance is returned even if both are exactly the same class.
And the first shared instance is replaced with the next one.
See codeigniter4/shield#802
Checklist: