Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Model inserts cast $primaryKey value when using Entity #7806

Merged
merged 5 commits into from
Aug 15, 2023
Merged

fix: Model inserts cast $primaryKey value when using Entity #7806

merged 5 commits into from
Aug 15, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 10, 2023

Description
Fixes #7797

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 10, 2023
@kenjis kenjis force-pushed the fix-model-cast-pk branch from 6980fad to e32feba Compare August 10, 2023 08:06
@kenjis kenjis mentioned this pull request Aug 10, 2023
Closed
@kenjis kenjis force-pushed the fix-model-cast-pk branch from e32feba to 5eef075 Compare August 10, 2023 08:40
MGatner
MGatner requested changes Aug 12, 2023
View reviewed changes
system/Model.php Show resolved Hide resolved
system/Model.php Outdated Show resolved Hide resolved
@kenjis kenjis mentioned this pull request Aug 13, 2023
Closed
22 tasks
@kenjis kenjis force-pushed the fix-model-cast-pk branch from 5eef075 to d82a9bb Compare August 14, 2023 02:10
@kenjis kenjis requested a review from MGatner August 14, 2023 02:20
@kenjis kenjis merged commit 513f9fc into codeigniter4:develop Aug 15, 2023
@kenjis kenjis deleted the fix-model-cast-pk branch August 15, 2023 01:05
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Model inserts the casted $primaryKey value when using an entity and casts.
2 participants
@kenjis @MGatner