Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Remove the Helpers ignore errors in phpstan-baseline.php #7776

Closed
wants to merge 2 commits into from

Conversation

jinny8813
Copy link
Contributor

@jinny8813 jinny8813 commented Aug 4, 2023

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@@ -16,7 +16,9 @@
/**
* Prints a Kint debug report and exits.
*
* @param array ...$vars
* @param mixed $vars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param mixed $vars
* @param array ...$vars

Dont use mixed, we want specify type. Applies to all

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6310

@jinny8813 jinny8813 closed this Aug 4, 2023
@jinny8813 jinny8813 deleted the phpstan_helpers branch August 4, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants