docs: [4.4] fix Rector's incorrect refactoring

[kenjis]

Description
Related #7649

The following refactoring will break the code.

Two tests will fail:

• AutoRouterImprovedTest::testFindsControllerAndMethodAndParam()
• AutoRouterImprovedTest::testPermitsURIWithUnderscoreParam()

1) system/Router/AutoRouterImproved.php:294

    ---------- begin diff ----------
@@ @@

             // Update the positions.
             $this->methodPos = $this->paramPos;
-            if ($params === []) {
-                $this->paramPos = null;
-            }
+            $this->paramPos = null;
             if ($this->paramPos !== null) {
                 $this->paramPos++;
             }
    ----------- end diff -----------

Applied rules:
 * RemoveAlwaysTrueIfConditionRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5449192482/jobs/9913186865

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• [] User guide updated
• Conforms to style guide

[samsonasik]

could you create a simple reproducible bug on https://getrector.com/demo , it seems correct just by looking at it, but probably it prefilled/unset in other side that cause side effect on the property value.

[kenjis]

@samsonasik Created rectorphp/rector#8039

[samsonasik]

@kenjis the @var seems can be used for it, see https://getrector.com/demo/93fe0739-0ee0-4587-9456-1c6901384da8

[kenjis]

@samsonasik Thanks. I removed skipping RemoveAlwaysTrueIfConditionRector,
and added @phpstan-var.

[kenjis]

The following error will be fixed by #7661

1) system/Commands/Utilities/Routes.php:118

    ---------- begin diff ----------
@@ @@
         $definedRouteCollector = new DefinedRouteCollector($collection);

         foreach ($definedRouteCollector->collect() as $route) {
-            if (is_string($route['handler']) || $route['handler'] instanceof Closure) {
-                $sampleUri = $uriGenerator->get($route['route']);
-                $filters   = $filterCollector->get($route['method'], $sampleUri);
-
-                $routeName = ($route['route'] === $route['name']) ? '»' : $route['name'];
-
-                $tbody[] = [
-                    strtoupper($route['method']),
-                    $route['route'],
-                    $routeName,
-                    $route['handler'],
-                    implode(' ', array_map('class_basename', $filters['before'])),
-                    implode(' ', array_map('class_basename', $filters['after'])),
-                ];
-            }
+            $sampleUri = $uriGenerator->get($route['route']);
+            $filters   = $filterCollector->get($route['method'], $sampleUri);
+            $routeName = ($route['route'] === $route['name']) ? '»' : $route['name'];
+            $tbody[] = [
+                strtoupper($route['method']),
+                $route['route'],
+                $routeName,
+                $route['handler'],
+                implode(' ', array_map('class_basename', $filters['before'])),
+                implode(' ', array_map('class_basename', $filters['after'])),
+            ];
         }

         if ($collection->shouldAutoRoute()) {
    ----------- end diff -----------

Applied rules:
 * RemoveAlwaysTrueIfConditionRector

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5471544778/jobs/9962789821?pr=7650

[samsonasik]

Thank you @kenjis