Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused non-empty array in RequestTrait #7620

Merged
merged 2 commits into from
Jun 26, 2023
Merged

refactor: remove unused non-empty array in RequestTrait #7620

merged 2 commits into from
Jun 26, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 26, 2023 •
edited by paulbalandan
Loading

Description
Supersedes and closes #7606

Fixes Rector check failure like https://github.com/codeigniter4/CodeIgniter4/actions/runs/5372608167/jobs/9746170218

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Jun 26, 2023
@kenjis kenjis requested a review from paulbalandan June 26, 2023 06:12
This was referenced Jun 26, 2023
Closed
Merged
@kenjis kenjis marked this pull request as draft June 26, 2023 06:40
@kenjis kenjis marked this pull request as ready for review June 26, 2023 06:40
@kenjis kenjis merged commit 1e7204b into codeigniter4:develop Jun 26, 2023
@kenjis kenjis deleted the refactor-RequestTrait branch June 26, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @paulbalandan